use array_values so params are still passed to scope #387

jamesburrow23 · 2019-11-25T19:56:07Z

Currently any filters that are using associative keys cannot be passed to the scope using the splat operator.

Scenario

suppose I have this scope on my model:

public function scopePublishedBetween($query, $start, $end)
    {
        return $query
            ->where('published_at', '>=', Carbon::parse($start))
            ->where('published_at', '<=', Carbon::parse($end));
    }

And I've allowed this scope in my query:

AllowedFilter::scope('published_between')

Now I pass my date range as an associative array in the request like so:

let params = {
    filter: {
        start: '2019-11-20',
        end: '2019-11-25',
    },
};

When the query builder executes this request I receive this error because the splat operator does not support unpacking associative arrays.

Symfony\Component\Debug\Exception\FatalThrowableError
Cannot unpack array with string keys

AlexVanderbist · 2020-01-22T12:43:08Z

Great, thanks!

use array_values so associative values are still passed to scope

86b6656

AlexVanderbist merged commit 1e7044d into spatie:master Jan 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use array_values so params are still passed to scope #387

use array_values so params are still passed to scope #387

jamesburrow23 commented Nov 25, 2019 •

edited

Loading

AlexVanderbist commented Jan 22, 2020

use array_values so params are still passed to scope #387

use array_values so params are still passed to scope #387

Conversation

jamesburrow23 commented Nov 25, 2019 • edited Loading

Scenario

AlexVanderbist commented Jan 22, 2020

jamesburrow23 commented Nov 25, 2019 •

edited

Loading